fix(cli): improve programmatic reliability for chat, auth, search, and image size - #124
Closed
hopelynd wants to merge 4 commits into
Closed
fix(cli): improve programmatic reliability for chat, auth, search, and image size#124hopelynd wants to merge 4 commits into
hopelynd wants to merge 4 commits into
Conversation
Normalize 1024x1024 / 1024×1024 to width*height before the API call, and reject unknown ratios locally with USAGE instead of a server 400.
…s false Non-streaming chat no longer forces enable_thinking=false, which breaks thinking-only models. Retry once with false only when the server demands it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enable_thinkinghelpers in core and use them intext chatandauth login: non-streaming requests default toenable_thinking: false, with a one-shot retry when the API requires a different value (true, false, or omit).WxHimage sizes (e.g.1024x1024), normalize toW*H, and reject unknown--sizevalues locally with USAGE.Test plan
vp test packages/core/tests/thinking.test.tsvp test packages/commands/tests/search-web-activate-hint.test.tsvp test packages/commands/tests/e2e/auth.e2e.test.ts(targeted login cases)vp checkvp test(full suite)bl text chat --dry-run --output json(non-stream request includesenable_thinking: false)bl search webwhen WebSearch MCP is not activated (hint includes marketplace URL)bl image generate --size 1024x1024accepts OpenAI-style size format